Attention is currently required from: daniel, laforge, neels. tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/36787?usp=email )
Change subject: ranap_common: Implement support for missing procedures ...................................................................... Patch Set 1: (3 comments) Patchset: PS1: I don't really understand what this is about TBH, just doing a quick read of the code for "unexpected" things and this seemed a bit weird to me, feel free to ignore if this is how it should be ... File src/ranap_common_ran.c: https://gerrit.osmocom.org/c/osmo-iuh/+/36787/comment/050f4484_42ff9ca5 PS1, Line 196: static int ran_ranap_rx_unsuccessful_msg_co(RANAP_SuccessfulOutcome_t *imsg, ranap_message *message) ran_ranap_rx_unsuccessful_msg_co takes a RANAP_SuccessfulOutcome_t as param and not some RANAP_UnsuccessfulOutcome_t https://gerrit.osmocom.org/c/osmo-iuh/+/36787/comment/38ab628c_4d80622b PS1, Line 247: rc = ran_ranap_rx_unsuccessful_msg_co(&pdu->choice.successfulOutcome, message); Not pdu->choice.unsuccessfulOutcome ? -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/36787?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: I7dea74102da8b610ff2a310c5814f5c89f08e7a6 Gerrit-Change-Number: 36787 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <lafo...@osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillm...@sysmocom.de> Gerrit-Reviewer: neels <nhofm...@sysmocom.de> Gerrit-Reviewer: pespin <pes...@sysmocom.de> Gerrit-CC: tnt <t...@246tnt.com> Gerrit-Attention: neels <nhofm...@sysmocom.de> Gerrit-Attention: laforge <lafo...@osmocom.org> Gerrit-Attention: daniel <dwillm...@sysmocom.de> Gerrit-Comment-Date: Wed, 15 May 2024 15:04:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment