Attention is currently required from: daniel, neels, pespin, tnt. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/36787?usp=email )
Change subject: ranap_common: Implement support for missing procedures ...................................................................... Patch Set 2: (3 comments) Patchset: PS1: > I don't really understand what this is about TBH, just doing a quick read of > the code for "unexpecte […] thanks, it was a simple copy+paste mistake. File src/ranap_common_ran.c: https://gerrit.osmocom.org/c/osmo-iuh/+/36787/comment/9f6380a6_a8ca699e PS1, Line 196: static int ran_ranap_rx_unsuccessful_msg_co(RANAP_SuccessfulOutcome_t *imsg, ranap_message *message) > ran_ranap_rx_unsuccessful_msg_co takes a RANAP_SuccessfulOutcome_t as param > and not some RANAP_Unsuc […] Done https://gerrit.osmocom.org/c/osmo-iuh/+/36787/comment/80125f9e_14235a47 PS1, Line 247: rc = ran_ranap_rx_unsuccessful_msg_co(&pdu->choice.successfulOutcome, message); > Not pdu->choice. […] Done -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/36787?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: I7dea74102da8b610ff2a310c5814f5c89f08e7a6 Gerrit-Change-Number: 36787 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <lafo...@osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillm...@sysmocom.de> Gerrit-Reviewer: neels <nhofm...@sysmocom.de> Gerrit-Reviewer: pespin <pes...@sysmocom.de> Gerrit-CC: tnt <t...@246tnt.com> Gerrit-Attention: neels <nhofm...@sysmocom.de> Gerrit-Attention: tnt <t...@246tnt.com> Gerrit-Attention: pespin <pes...@sysmocom.de> Gerrit-Attention: daniel <dwillm...@sysmocom.de> Gerrit-Comment-Date: Wed, 15 May 2024 15:10:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: tnt <t...@246tnt.com> Gerrit-MessageType: comment