Attention is currently required from: fixeria, pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/36760?usp=email )
Change subject: libmsc: add X5 timer for delaying LU connections ...................................................................... Patch Set 4: (3 comments) Patchset: PS4: thanks for the explanation! If the SMSC has a response message to the readyForSM saying "ack, i had nothing to submit", then I would again like to remove this timeout, as soon as osmo-msc supports those messages. But I see the point and this patch is simple enough, also the default is zero, and a user has control. I'd +2 now, but I found a minor detail: the timer number. see below. (also a bikeshed, maybe you agree, or nm if not.) File src/libmsc/msc_a.c: https://gerrit.osmocom.org/c/osmo-msc/+/36760/comment/591de529_32838275 PS4, Line 164: static void msc_a_put_use_lu(struct msc_a *msc_a) (i'd prefer the name msc_a_put_lu_deferred() 1: the prefix is 'MSC_A_USE' and 'LOCATION_UPDATING' is what we put and get. 2: the name should reflect that it may not happen immediately. ) File src/libmsc/ran_infra.c: https://gerrit.osmocom.org/c/osmo-msc/+/36760/comment/1e891f84_965b620f PS4, Line 47: { .T = -5, .default_val = 0, .unit = OSMO_TDEF_MS, .desc = "Additional delay for LU connections" }, \ you need to add a new timer entry to the list in the wiki: https://osmocom.org/projects/cellular-infrastructure/wiki/List_of_Timer_numbers This is the definitive source for new timers. First add the new timer there, even before submitting a patch, to make sure no-one else uses the same. I would encourage to avoid re-using the same timer numbers. By that scheme, currently the next available X timer is X 36 or -36. The description line on the wiki page should be identical to the t_def doc string. Thanks! -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/36760?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ic519cab55d65e47b2636124427dab1a1d80fab78 Gerrit-Change-Number: 36760 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: neels <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-Attention: fixeria <[email protected]> Gerrit-Attention: pespin <[email protected]> Gerrit-Comment-Date: Mon, 27 May 2024 23:59:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
