Attention is currently required from: fixeria, pespin.
neels has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-msc/+/36760?usp=email )
Change subject: libmsc: add X5 timer for delaying LU connections
......................................................................
Patch Set 4:
(2 comments)
Patchset:
PS4:
Just an idea:
Would it make sense to not apply this delay on periodic LU,
i.e. delay only on IMSI-attach LU?
Or maybe separate timers for periodic LU and IMSI-attach LU?
We have these types of LU:
osmo-msc/include/osmocom/msc/vlr.h
<pre>
enum vlr_lu_type {
VLR_LU_TYPE_PERIODIC,
VLR_LU_TYPE_IMSI_ATTACH,
VLR_LU_TYPE_REGULAR,
};
</pre>
A periodic LU happens every 15 minutes for each active subscriber, so it could
be significant.
File src/libmsc/ran_infra.c:
https://gerrit.osmocom.org/c/osmo-msc/+/36760/comment/82606554_7654435a
PS4, Line 47: { .T = -5, .default_val = 0, .unit = OSMO_TDEF_MS, .desc =
"Additional delay for LU connections" }, \
> you need to add a new timer entry to the list in the wiki: […]
(may I suggest the doc string:
"Delay connection release after LU. Useful to optimize an SMSC to dispatch
pending messages within the initial connection."
- clarify "release"; otherwise a misunderstanding could be: "let the MS wait
before accepting its LU"
- mention motivation
- vty doc strings are allowed to be long
--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/36760?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: Ic519cab55d65e47b2636124427dab1a1d80fab78
Gerrit-Change-Number: 36760
Gerrit-PatchSet: 4
Gerrit-Owner: fixeria <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-Reviewer: neels <[email protected]>
Gerrit-Reviewer: pespin <[email protected]>
Gerrit-Attention: fixeria <[email protected]>
Gerrit-Attention: pespin <[email protected]>
Gerrit-Comment-Date: Tue, 28 May 2024 01:31:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: neels <[email protected]>
Gerrit-MessageType: comment
