Attention is currently required from: jolly. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37519?usp=email )
Change subject: Fix BTS_Tests_ASCI.TC_vbs_notification, add missing SI1 ...................................................................... Patch Set 1: (4 comments) File bts/BTS_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37519/comment/c78d58d7_1276b444 PS1, Line 442: function f_rsl_bcch_fill_raw(RSL_IE_SysinfoType rsl_si_type, octetstring si_enc) this one can be friend. https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37519/comment/3b79a406_5112dbe5 PS1, Line 448: friend function f_rsl_bcch_fill(RSL_IE_SysinfoType rsl_si_type, template (value) SystemInformation si_dec) why is this changed? https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37519/comment/d3bc68a5_f6ef1d70 PS1, Line 4925: function f_TC_si_sched(float duration := 8.0) runs on test_CT { why is this changed? File bts/BTS_Tests_ASCI.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37519/comment/5012afa9_30b6f66e PS1, Line 47: friend function f_init_nch_position() runs on test_CT { this one can be private. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37519?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I65dc55da78bc53a1265124e6b6f6bb9a1650206e Gerrit-Change-Number: 37519 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <[email protected]> Gerrit-Attention: jolly <[email protected]> Gerrit-Comment-Date: Wed, 17 Jul 2024 10:42:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
