Attention is currently required from: fixeria, pespin. jolly has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37519?usp=email )
Change subject: Fix BTS_Tests_ASCI.TC_vbs_notification, add missing SI1 ...................................................................... Patch Set 1: (4 comments) File bts/BTS_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37519/comment/89a77f60_4f43255b PS1, Line 442: function f_rsl_bcch_fill_raw(RSL_IE_SysinfoType rsl_si_type, octetstring si_enc) > this one can be friend. Done https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37519/comment/2a1ab912_d5720d57 PS1, Line 448: friend function f_rsl_bcch_fill(RSL_IE_SysinfoType rsl_si_type, template (value) SystemInformation si_dec) > why is this changed? I did not cleanup the patch before submitting. https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37519/comment/2ec6b872_124f9151 PS1, Line 4925: function f_TC_si_sched(float duration := 8.0) runs on test_CT { > why is this changed? I did not cleanup the patch before submitting. File bts/BTS_Tests_ASCI.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37519/comment/d9ba8313_f1d6f7cc PS1, Line 47: friend function f_init_nch_position() runs on test_CT { > this one can be private. Done -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37519?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I65dc55da78bc53a1265124e6b6f6bb9a1650206e Gerrit-Change-Number: 37519 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <[email protected]> Gerrit-CC: pespin <[email protected]> Gerrit-Attention: pespin <[email protected]> Gerrit-Attention: fixeria <[email protected]> Gerrit-Comment-Date: Thu, 18 Jul 2024 08:44:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <[email protected]> Gerrit-MessageType: comment
