Attention is currently required from: dexter.

laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/pysim/+/37641?usp=email )

Change subject: pySim-shell: enable export of DF and ADF files
......................................................................


Patch Set 1:

(1 comment)

File pySim-shell.py:

https://gerrit.osmocom.org/c/pysim/+/37641/comment/c77818b5_571b2542
PS1, Line 500: When walking through the file system tree the action must not
             :         # always restore the currently selected file
I think the code is doing the opposite of what the comment states?  IF the 
action *must not restore* the selected file, then the code below would always 
be hit and always generate the RuntimeError



--
To view, visit https://gerrit.osmocom.org/c/pysim/+/37641?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I3ee661dbae5c11fec23911775f352ac13bc2c6e5
Gerrit-Change-Number: 37641
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <[email protected]>
Gerrit-Attention: dexter <[email protected]>
Gerrit-Comment-Date: Sat, 27 Jul 2024 08:24:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Reply via email to