Attention is currently required from: fixeria, laforge. dexter has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/37641?usp=email )
Change subject: pySim-shell: enable export of DF and ADF files ...................................................................... Patch Set 2: (2 comments) File pySim-shell.py: https://gerrit.osmocom.org/c/pysim/+/37641/comment/7b0ae629_92742cca?usp=email : PS1, Line 500: When walking through the file system tree the action must not : # always restore the currently selected file > I think the code is doing the opposite of what the comment states? IF the > action *must not restore* […] Thanks. The "not" is of course wrong. https://gerrit.osmocom.org/c/pysim/+/37641/comment/b1d58645_73d2b54f?usp=email : PS1, Line 651: include_df > let's stick to using dash in command line arguments […] We are using this style in many places. Maybe we should go through and fix it everywhere? -- To view, visit https://gerrit.osmocom.org/c/pysim/+/37641?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I3ee661dbae5c11fec23911775f352ac13bc2c6e5 Gerrit-Change-Number: 37641 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <[email protected]> Gerrit-CC: laforge <[email protected]> Gerrit-Attention: laforge <[email protected]> Gerrit-Attention: fixeria <[email protected]> Gerrit-Comment-Date: Mon, 05 Aug 2024 13:27:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <[email protected]> Comment-In-Reply-To: fixeria <[email protected]>
