Attention is currently required from: dexter. laforge has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/37840?usp=email )
Change subject: ara_m: use class byte of current lchan ...................................................................... Patch Set 1: Code-Review-1 (1 comment) Patchset: PS1: I agree this needs a fix - but I think the proper solution for this is to handle this generically within the scc layer. It should offer two flavours of the send_apdu_checksw() method: one that patches CLA with the lchan number, and one that doesn't. This could be two methods, or an optional argument to the existing method. The default should be to do the lchan-patching; only special commands should be excempt from it (like the OPEN CHANNEL). This way we can avoid exposing all those low-level details to other modules in the code base. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/37840?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ie3e48678f178a488bfaea6cc2b9a3e18145a8d10 Gerrit-Change-Number: 37840 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <[email protected]> Gerrit-Attention: dexter <[email protected]> Gerrit-Comment-Date: Fri, 16 Aug 2024 16:59:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes
