Attention is currently required from: dexter, fixeria. laforge has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/37840?usp=email )
Change subject: ara_m: use class byte of current lchan ...................................................................... Patch Set 6: Code-Review-1 (1 comment) Patchset: PS6: I think if you make apply_lchan=True the default (to which I agree!), then you have to audit the existing code to set apply_lchan=False on all commands where it must not be set. Off my head, this would at least be the command for opening a logical channel (MANAGE CHANNEL). You can possibl use the libosmocore/src/sim/class_tables.c file as a helper. If it is correct, uicc_ins_tbl_80 is registered with mask FF, so TERMINAL PROFILE, ENVELOPE, FETCH, TERMINAL RESPONS, SUSPEND UICC and EXCHANGE CAPABILITIES would also not report any non-zero lchan. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/37840?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ie3e48678f178a488bfaea6cc2b9a3e18145a8d10 Gerrit-Change-Number: 37840 Gerrit-PatchSet: 6 Gerrit-Owner: dexter <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <[email protected]> Gerrit-Reviewer: laforge <[email protected]> Gerrit-Attention: fixeria <[email protected]> Gerrit-Attention: dexter <[email protected]> Gerrit-Comment-Date: Thu, 22 Aug 2024 11:01:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes
