Attention is currently required from: neels. pespin has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37882?usp=email )
Change subject: ctrl, hnbgw: access rate counter groups by given ID instead of index ...................................................................... Patch Set 2: (2 comments) Patchset: PS2: This extra level of indirection having to specify a map makes stuff too complex for no reason imho. In the end, the ttcn3 user of the rate_ctr knows whether it needs to use a string or a index to access the counter, so it can use whatever is needed directly. I think this should be implemented by: * Have new generic APIs of the index-based existing ones, where instead of an index a string is passed. * Change the existing index-based API implementations to use the ones above by doing str2int(index). Then, the user can use those APIs directly, eg. passing a string of a Cell Id or whatever may be needed. File library/Osmocom_CTRL_Functions.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37882/comment/b3d83b72_20678db6?usp=email : PS2, Line 161: * cell ID instad, pass in a mapping of index to cell id, to use the name given by rate_ctr_group_set_name() instead -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37882?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I70e74e7554482df67aa1d90bc04314124dea444f Gerrit-Change-Number: 37882 Gerrit-PatchSet: 2 Gerrit-Owner: neels <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <[email protected]> Gerrit-Attention: neels <[email protected]> Gerrit-Comment-Date: Wed, 21 Aug 2024 09:25:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No
