Attention is currently required from: fixeria, laforge. dexter has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/37819?usp=email )
Change subject: Testsuite for pySim-shell with real cards ...................................................................... Patch Set 15: (2 comments) File tests/pySim-shell_test/ara_m/test.py: https://gerrit.osmocom.org/c/pysim/+/37819/comment/007c70ef_b4cb60d7?usp=email : PS15, Line 27: self.setup(__file__) > Calling this in each test case can be avoided by defining method `setUp` in > `UnittestUtils`. […] Initially I had it in the constructor of UnittestUtils, but I ran into problems because I want t display the unittest name, which I deduct from the file name. Since I could not get the file name through inspection methods I gave up and opted for having this setup method. Do you have any ideas? I would love to get rid of this method call. https://gerrit.osmocom.org/c/pysim/+/37819/comment/ce417b64_c80a97cd?usp=email : PS15, Line 35: self.cleanup() > Likewise, calling this in each test case can be avoided by defining method > `tearDown` in `UnittestUt […] This could actually work. I will try it. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/37819?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ieae1330767a6e55e62437f5f988a0d33b727b5de Gerrit-Change-Number: 37819 Gerrit-PatchSet: 15 Gerrit-Owner: dexter <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <[email protected]> Gerrit-CC: fixeria <[email protected]> Gerrit-Attention: laforge <[email protected]> Gerrit-Attention: fixeria <[email protected]> Gerrit-Comment-Date: Mon, 02 Sep 2024 08:10:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <[email protected]>
