Attention is currently required from: dexter, fixeria.

laforge has posted comments on this change by dexter. ( 
https://gerrit.osmocom.org/c/pysim/+/37819?usp=email )

Change subject: Testsuite for pySim-shell with real cards
......................................................................


Patch Set 15:

(1 comment)

File tests/pySim-shell_test/ara_m/test.py:

https://gerrit.osmocom.org/c/pysim/+/37819/comment/b4d8befa_4af41374?usp=email :
PS15, Line 35: self.cleanup()
> This could actually work. I will try it.
I would prefer a solution that does not have to define a class variable in 
every derived class (testcase class).  that's almost as cumbersome as calling 
the setup method from each derived class. Solving it without any extra lines 
here, in a generic way, should be preferable.



--
To view, visit https://gerrit.osmocom.org/c/pysim/+/37819?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Ieae1330767a6e55e62437f5f988a0d33b727b5de
Gerrit-Change-Number: 37819
Gerrit-PatchSet: 15
Gerrit-Owner: dexter <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-CC: fixeria <[email protected]>
Gerrit-Attention: fixeria <[email protected]>
Gerrit-Attention: dexter <[email protected]>
Gerrit-Comment-Date: Mon, 02 Sep 2024 14:39:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <[email protected]>
Comment-In-Reply-To: dexter <[email protected]>

Reply via email to