Attention is currently required from: dexter, pespin.

fixeria has posted comments on this change by pespin. ( 
https://gerrit.osmocom.org/c/osmo-bsc/+/38076?usp=email )

Change subject: pcu_tx_rach_ind(): Avoid forwarding chan_rqd to PCU if not 
expected
......................................................................


Patch Set 1: Code-Review+1

(1 comment)

File src/osmo-bsc/pcu_sock.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/38076/comment/a8c73166_bd160d76?usp=email
 :
PS1, Line 426: bsc_co_located_pcu
Shouldn't this check be done in a common place like `pcu_sock_send()`?



--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/38076?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Ic12aa9842227b2d815bb91f8587c8b258d07f169
Gerrit-Change-Number: 38076
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <[email protected]>
Gerrit-Reviewer: fixeria <[email protected]>
Gerrit-Attention: pespin <[email protected]>
Gerrit-Attention: dexter <[email protected]>
Gerrit-Comment-Date: Tue, 10 Sep 2024 15:24:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes

Reply via email to