laforge has submitted this change. (
https://gerrit.osmocom.org/c/osmo-bsc/+/38076?usp=email )
Change subject: pcu_tx_rach_ind(): Avoid forwarding chan_rqd to PCU if not
expected
......................................................................
pcu_tx_rach_ind(): Avoid forwarding chan_rqd to PCU if not expected
Change-Id: Ic12aa9842227b2d815bb91f8587c8b258d07f169
---
M src/osmo-bsc/pcu_sock.c
1 file changed, 6 insertions(+), 1 deletion(-)
Approvals:
fixeria: Looks good to me, but someone else must approve
laforge: Looks good to me, approved
Jenkins Builder: Verified
diff --git a/src/osmo-bsc/pcu_sock.c b/src/osmo-bsc/pcu_sock.c
index 7b1aeae..d4eee44 100644
--- a/src/osmo-bsc/pcu_sock.c
+++ b/src/osmo-bsc/pcu_sock.c
@@ -419,10 +419,15 @@
/* Bail if no PCU is connected */
if (!pcu_connected(bts->network)) {
- LOG_BTS(bts, DRSL, LOGL_ERROR, "CHAN RQD(GPRS) but PCU not
connected!\n");
+ LOG_BTS(bts, DPCU, LOGL_ERROR, "CHAN RQD(GPRS) but PCU not
connected!\n");
return -ENODEV;
}
+ if (!bsc_co_located_pcu(bts)) {
+ LOG_BTS(bts, DPCU, LOGL_ERROR, "CHAN RQD(GPRS) on BTS whose PCU
is not BSC-colocated!\n");
+ return -EINVAL;
+ }
+
LOG_BTS(bts, DPCU, LOGL_INFO, "Sending RACH indication: qta=%d, ra=%d, "
"fn=%d\n", qta, ra, fn);
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/38076?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Ic12aa9842227b2d815bb91f8587c8b258d07f169
Gerrit-Change-Number: 38076
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <[email protected]>
Gerrit-Reviewer: fixeria <[email protected]>
Gerrit-Reviewer: laforge <[email protected]>
