Attention is currently required from: pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37955?usp=email )
Change subject: Introduce initial metrics support ...................................................................... Patch Set 2: (1 comment) File src/s1gw_metrics.erl: https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37955/comment/e6c0eb03_00ecfc5d?usp=email : PS2, Line 150: LOG_ERROR I believe this should be `LOG_DEBUG`. Also, two prints is redundant, one would be enough. -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37955?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I952e198238384dca4be94f91a01d7cfff0a1471f Gerrit-Change-Number: 37955 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <[email protected]> Gerrit-Attention: pespin <[email protected]> Gerrit-Comment-Date: Sun, 15 Sep 2024 10:47:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No
