Attention is currently required from: fixeria. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37955?usp=email )
Change subject: Introduce initial metrics support ...................................................................... Patch Set 5: Code-Review+1 (2 comments) File include/s1gw_metrics.hrl: https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37955/comment/f3584121_baee5cb9?usp=email : PS3, Line 9: S1GW_CTR_S1AP_PROXY_IN_PKT > This one was not referenced anywhere, so I removed it. ACK File src/sctp_proxy.erl: https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37955/comment/c976b90c_7bc37b49?usp=email : PS4, Line 109: S1GW_CTR_S1AP_PROXY_UPLINK_PACKETS_QUEUED > @[email protected] do we really want this as a counter? IMO, gauge alone > would do the job. […] The fact that is not special doesn't really mean to me that we should not be counting it. Some counters actually showcase the good usual behavior of the program, like calls being established, etc. It can also be used for instance to get a glimpse on the amount of packets being forwarded over time, whether the traffic is bursty or not, etc. -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37955?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I952e198238384dca4be94f91a01d7cfff0a1471f Gerrit-Change-Number: 37955 Gerrit-PatchSet: 5 Gerrit-Owner: pespin <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <[email protected]> Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-Attention: fixeria <[email protected]> Gerrit-Comment-Date: Thu, 26 Sep 2024 14:01:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: fixeria <[email protected]>
