Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-bts/+/38301?usp=email )
Change subject: csd_v110: properly set bit E2 for TCH/F4.8 NT ...................................................................... Patch Set 2: Code-Review+1 (2 comments) File src/common/csd_v110.c: https://gerrit.osmocom.org/c/osmo-bts/+/38301/comment/5121552c_66f0cf96?usp=email : PS1, Line 113: if ((i & 1) == 0) { /* executed for Q1/Q3 */ > I prefer using hex-notation when dealing with values sent/received over the > wire/radio. […] Done https://gerrit.osmocom.org/c/osmo-bts/+/38301/comment/47530bdc_c42a0a50?usp=email : PS1, Line 125: * Q4 | =1 | =1 > Yes, we do not execute this code for `i == 3` (i.e. […] Ah I didn't see it was a loop, fine then. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/38301?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: If8307a9ce0fdc6da45157149ccef7b840ff9d9b3 Gerrit-Change-Number: 38301 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <[email protected]> Gerrit-Attention: fixeria <[email protected]> Gerrit-Comment-Date: Thu, 26 Sep 2024 19:50:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: fixeria <[email protected]> Comment-In-Reply-To: pespin <[email protected]>
