Attention is currently required from: fixeria. falconia has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-bts/+/38301?usp=email )
Change subject: csd_v110: properly set bit E2 for TCH/F4.8 NT ...................................................................... Patch Set 3: Code-Review-2 (1 comment) Patchset: PS3: Unfortunately this approach cannot work because bit E7 simply does not exist in NT mode: that bit position gets replaced by one of D-prime bits belonging to the RLP frame. You reference TS 44.021 Figure 1 - but that figure is part of section 10.2.1.1, and that entire part of the spec (all of chapter 10) is applicable only to transparent services. NT services are covered by chapter 12 of this spec instead, plus chapter 15 of TS 48.020 that is more relevant. The only correct solution is to extend the internal API to `csd_v110_rtp_encode()` and pass a flag that indicates alignment with TDMA multiframe structure. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/38301?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: If8307a9ce0fdc6da45157149ccef7b840ff9d9b3 Gerrit-Change-Number: 38301 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: falconia <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-Attention: fixeria <[email protected]> Gerrit-Comment-Date: Thu, 26 Sep 2024 21:05:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes
