Jenkins Builder has posted comments on this change by pespin. ( 
https://gerrit.osmocom.org/c/libosmo-sigtran/+/38375?usp=email )

Change subject: ss7 vty: Fix insert order of routes with higher priority
......................................................................


Patch Set 1:

(2 comments)

File src/osmo_ss7.c:

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-19108):
https://gerrit.osmocom.org/c/libosmo-sigtran/+/38375/comment/72d85dc6_86140da5?usp=email
 :
PS1, Line 849:  if (!rt->cfg.linkset_name) {
braces {} are not necessary for single statement blocks


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-19108):
https://gerrit.osmocom.org/c/libosmo-sigtran/+/38375/comment/8cb42d66_e4ed90dd?usp=email
 :
PS1, Line 916:  if (ss7_route_inserted(rt)) {
suspect code indent for conditional statements (8, 24)



--
To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/38375?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: I6e7b5e3f06ae2c9468da58c55d2f42cbcd777218
Gerrit-Change-Number: 38375
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <[email protected]>
Gerrit-CC: Jenkins Builder
Gerrit-Comment-Date: Wed, 09 Oct 2024 18:04:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No

Reply via email to