pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/38375?usp=email )
Change subject: ss7 vty: Fix insert order of routes with higher priority ...................................................................... Patch Set 2: (1 comment) File tests/vty/osmo_stp_route_prio.vty: https://gerrit.osmocom.org/c/libosmo-sigtran/+/38375/comment/e906cc78_1e043221?usp=email : PS2, Line 87: 3.2.1/14 0 as3 ? ? ? As it can be seen, the default prio (0) when no prio is selected is the highest one. Now comes the question whether this is desired, or we should be setting prio 0xffffff by default (the lower one), or some intermediate value like 0xff00000. This would also mean changing old behavior, but in this case we know for sure the priority stuff was not being used at all anywhere so it shouldn't be a problem. -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/38375?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I6e7b5e3f06ae2c9468da58c55d2f42cbcd777218 Gerrit-Change-Number: 38375 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Wed, 09 Oct 2024 18:14:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No
