Attention is currently required from: pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38573?usp=email )
Change subject: RUA_Emulation: Support passing no RANAP PDU in RUA_Disc_Req ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File library/rua/RUA_Templates.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38573/comment/01d020cf_fa971957?usp=email : PS1, Line 201: ts_RUA_Disconnect_no_ranap Adding a separate template is of course an easier approach, but you could still make the `ranap_msg` param optional in `ts_RUA_Disconnect` by using a helper function that would generate `protocolIEs[]` conditionally. I did this recently in https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38578/1/library/s1ap/S1AP_Templates.ttcn, just in case you need an example. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38573?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Id9c3d5a1e45aa6ca58a71b61e142dc041a335cc9 Gerrit-Change-Number: 38573 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <[email protected]> Gerrit-Reviewer: osmith <[email protected]> Gerrit-Attention: pespin <[email protected]> Gerrit-Comment-Date: Wed, 30 Oct 2024 16:07:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes
