Attention is currently required from: fixeria. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38573?usp=email )
Change subject: RUA_Emulation: Support passing no RANAP PDU in RUA_Disc_Req ...................................................................... Patch Set 1: (1 comment) File library/rua/RUA_Templates.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38573/comment/62a97821_0ee755d0?usp=email : PS1, Line 201: ts_RUA_Disconnect_no_ranap > Adding a separate template is of course an easier approach, but you could > still make the `ranap_msg` […] Yeah I saw, but I'm simply following the same stuff done in this file already in other templates. Moreover, in RUA the fact that there's or not a RANAP implies a lot of stuff 8as I'm fixing now in osmo-hnbgw), eg. abnormal vs normal condition, so I think it's good having it as a separate template. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38573?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Id9c3d5a1e45aa6ca58a71b61e142dc041a335cc9 Gerrit-Change-Number: 38573 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <[email protected]> Gerrit-Reviewer: osmith <[email protected]> Gerrit-Attention: fixeria <[email protected]> Gerrit-Comment-Date: Wed, 30 Oct 2024 16:44:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <[email protected]>
