fixeria has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38586?usp=email )
Change subject: library/gsup: fix wrong IE order in f_gen_tr_ss_ies
......................................................................
library/gsup: fix wrong IE order in f_gen_tr_ss_ies
libosmocore's GSUP encoder puts the OSMO_GSUP_MESSAGE_CLASS_IE
before OSMO_GSUP_{SOURCE,DESTINATION}_NAME_IE, not after. We
use 'record of' in GSUP_Types, so the order does matter.
Change-Id: I5aafbc885d3b78fd37f84feebf5dab1255d51eb1
---
M library/GSUP_Templates.ttcn
1 file changed, 4 insertions(+), 7 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks
refs/changes/86/38586/1
diff --git a/library/GSUP_Templates.ttcn b/library/GSUP_Templates.ttcn
index 0abc489..bf189e1 100644
--- a/library/GSUP_Templates.ttcn
+++ b/library/GSUP_Templates.ttcn
@@ -1408,7 +1408,9 @@
idx := idx + 1;
}
- /* FIXME: OSMO_GSUP_MESSAGE_CLASS_IE goes here */
+ /* OSMO_GSUP_MESSAGE_CLASS_IE (may or may not be present) */
+ ies[idx] := *;
+ idx := idx + 1;
/* OSMO_GSUP_{SOURCE,DESTINATION}_NAME_IE */
if (ispresent(src_name)) {
@@ -1426,12 +1428,7 @@
idx := idx + 1;
}
- /* the GSUP Message Class IE is optional, as old implementations don't
have it yet */
- var template GSUP_IEs ies2 := ies;
- ies2[idx] := tr_GSUP_IE_Message_Class(OSMO_GSUP_MESSAGE_CLASS_USSD);
- idx := idx + 1;
-
- return (ies, ies2);
+ return ies;
}
template (value) GSUP_PDU
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38586?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I5aafbc885d3b78fd37f84feebf5dab1255d51eb1
Gerrit-Change-Number: 38586
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <[email protected]>
