Attention is currently required from: fixeria, lynxis lazus, pespin.

laforge has posted comments on this change by fixeria. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38586?usp=email )

Change subject: library/gsup: fix wrong IE order in f_gen_tr_ss_ies
......................................................................


Patch Set 6:

(1 comment)

File library/GSUP_Templates.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38586/comment/3935ef90_4fdb3b3e?usp=email
 :
PS2, Line 1412:         ies[idx] := *;
> This patch is not perfect, but at least it would make the templates match 
> messages with the Message  […]
please add a link to the eclipse.org issue to the code and keep (or add a new) 
FIXME.  Also, please try to drive a discussion in the TITAN forum how on earh 
one is supposed to achieve something like our goal in a protocol with mandatory 
and optional IEs.



--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38586?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I5aafbc885d3b78fd37f84feebf5dab1255d51eb1
Gerrit-Change-Number: 38586
Gerrit-PatchSet: 6
Gerrit-Owner: fixeria <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: lynxis lazus <[email protected]>
Gerrit-Reviewer: pespin <[email protected]>
Gerrit-CC: laforge <[email protected]>
Gerrit-Attention: pespin <[email protected]>
Gerrit-Attention: fixeria <[email protected]>
Gerrit-Attention: lynxis lazus <[email protected]>
Gerrit-Comment-Date: Sun, 10 Nov 2024 13:16:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <[email protected]>
Comment-In-Reply-To: fixeria <[email protected]>

Reply via email to