Attention is currently required from: fixeria, laforge.
pespin has posted comments on this change by fixeria. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38584?usp=email )
Change subject: library/gsup: rework f_gen_{tr,ts}_ss_ies() and SS templates
......................................................................
Patch Set 2:
(2 comments)
Patchset:
PS2:
I find this commit really difficult to review, with different stuff in it.
Can we easily split all the template fixup from the change in logic which makes
the test pass now?
File library/GSUP_Templates.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38584/comment/c1c97a21_753fa16b?usp=email
:
PS2, Line 1330: private function f_gen_ts_ss_ies(template (value) hexstring
imsi,
You could split this big chunk of changes and move all the "(present)" and
"(value)" into another patch (like the previous one), but fine anyway.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38584?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ia611ffa3845d48c5553c70f10981aa029d00d873
Gerrit-Change-Number: 38584
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-CC: pespin <[email protected]>
Gerrit-Attention: laforge <[email protected]>
Gerrit-Attention: fixeria <[email protected]>
Gerrit-Comment-Date: Wed, 06 Nov 2024 15:57:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
