Attention is currently required from: laforge, pespin.
fixeria has posted comments on this change by fixeria. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38584?usp=email )
Change subject: library/gsup: rework f_gen_{tr,ts}_ss_ies() and SS templates
......................................................................
Patch Set 4:
(2 comments)
This change is ready for review.
File library/GSUP_Templates.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38584/comment/4c4cdf47_7ea34370?usp=email
:
PS2, Line 1330: private function f_gen_ts_ss_ies(template (value) hexstring
imsi,
> You could split this big chunk of changes and move all the "(present)" and
> "(value)" into another pa […]
See https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38689.
File library/GSUP_Templates.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38584/comment/956ef41d_3cb1c809?usp=email
:
PS3, Line 1415: else if (istemplatekind(destination_name, "*"))
> TODO: separate commit
I moved this chunk to https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38585.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38584?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ia611ffa3845d48c5553c70f10981aa029d00d873
Gerrit-Change-Number: 38584
Gerrit-PatchSet: 4
Gerrit-Owner: fixeria <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-CC: pespin <[email protected]>
Gerrit-Attention: laforge <[email protected]>
Gerrit-Attention: pespin <[email protected]>
Gerrit-Comment-Date: Fri, 08 Nov 2024 08:43:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <[email protected]>
Comment-In-Reply-To: fixeria <[email protected]>
