Attention is currently required from: pespin. fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/libosmo-abis/+/38752?usp=email )
Change subject: raa_prime_encode: rework is_z_seq() to improve performance ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: > Is it really improving performance? Does this really matter? I haven't done any measurements, and I know that "premature optimization is the root of all evil". But in the case of osmo-bts.git this code is executed one or several times for each TCH/F14.4 TCH.ind coming from the PHY every 20 ms. As I general rule, I believe it's better to avoid `if` statements in loops if they can be avoided. This way the compiler can easily unroll loops. -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/38752?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I43f4a85102114b51a8f2d9fa8fe3b941800b56fa Gerrit-Change-Number: 38752 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: falconia <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-Attention: pespin <[email protected]> Gerrit-Comment-Date: Mon, 18 Nov 2024 11:56:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <[email protected]>
