Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/libosmo-abis/+/38752?usp=email )
Change subject: raa_prime_encode: rework is_z_seq() to improve performance ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: > I haven't done any measurements, and I know that "premature optimization is > the root of all evil". […] In this case with older code can also unrol the loop, and it has early return, so I'm not really sure it's really an improvement... I don't really think this has an impact at all running once every 20ms. -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/38752?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I43f4a85102114b51a8f2d9fa8fe3b941800b56fa Gerrit-Change-Number: 38752 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: falconia <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-Attention: fixeria <[email protected]> Gerrit-Comment-Date: Mon, 18 Nov 2024 12:09:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <[email protected]> Comment-In-Reply-To: pespin <[email protected]>
