Patch Set 4: (3 comments)
https://gerrit.osmocom.org/#/c/6158/4/ggsn_tests/GGSN_Tests.ttcn File ggsn_tests/GGSN_Tests.ttcn: PS4, Line 751: ''O in a receive template you normally assign a default value of ? or in this case maybe even *, to make sure unless something is specified, it will match all ICMPv4 echo reply packets, not just those with zero-length data section (like in your case). PS4, Line 914: ''O same as above Line 1050: [] GTPU.receive(tr_GTPU_GPDU(g_peer_u, ?)) -> value ud { the generally mroe elegant solution would be to "stack" a translation port or dual-faced ports (I call them *_CodecPort.ttcn) on top of the GTPU port. This port will simply do the encoding/decoding of the payload, so that you can directly match on the inner IP header rather than having to manually do this. TTCN-3 also has some syntactic sugar called "decmatch" which allows you to achive what is written here in much less lines of code, but there's no need to change it now, this is just a notice in case you end up with this problem again. -- To view, visit https://gerrit.osmocom.org/6158 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib9c6043a6cd3b6622782ec7e7fcd2815101755ba Gerrit-PatchSet: 4 Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Owner: Pau Espin Pedrol <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Pau Espin Pedrol <[email protected]> Gerrit-HasComments: Yes
