Patch Set 4:

(1 comment)

https://gerrit.osmocom.org/#/c/6158/4/ggsn_tests/GGSN_Tests.ttcn
File ggsn_tests/GGSN_Tests.ttcn:

Line 1050:                      [] GTPU.receive(tr_GTPU_GPDU(g_peer_u, ?)) -> 
value ud {
> the generally mroe elegant solution would be to "stack" a translation port 
I spent some time looking at the different stuff you proposed here but couldn't 
find something which I could reasonably write.
Stacking a new port: afaiu, I'd need to create a new GTPU_IP4+GTPU_IP6 and/or 
even a GTPU_ICMP4+GTPUICMP6, but anyway I'm mixing IPv4 and IPv6 in my tests 
(ie trying to send an IPv4 over an IPv6 pdp ctx) which would mean I'd need to 
create several ports instead of just having the GTPU port, so I don't think 
it's worth it in this case.

decmatch: I couldn't find any good example from which I could clearly 
understand how it works. It seems we are neither using it yet in 
osmo-ttcn3-hacks.

I think I'll fix the other comment and leave this as it is now.


-- 
To view, visit https://gerrit.osmocom.org/6158
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib9c6043a6cd3b6622782ec7e7fcd2815101755ba
Gerrit-PatchSet: 4
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol <[email protected]>
Gerrit-Reviewer: Harald Welte <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Pau Espin Pedrol <[email protected]>
Gerrit-HasComments: Yes

Reply via email to