Attention is currently required from: neels. Hoernchen has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/osmo-trx/+/39359?usp=email )
Change subject: comma_delimited_to_vector() optimization CID#465430 ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Patchset: PS1: This is fine, but a really fast version would just slice with c++17 and a string_view without streams. -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/39359?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I30e57c6a9df39552bc4f8c18d27bc421f5c60f49 Gerrit-Change-Number: 39359 Gerrit-PatchSet: 1 Gerrit-Owner: neels <[email protected]> Gerrit-Reviewer: Hoernchen <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <[email protected]> Gerrit-Reviewer: laforge <[email protected]> Gerrit-Attention: neels <[email protected]> Gerrit-Comment-Date: Thu, 23 Jan 2025 11:04:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes
