laforge has submitted this change. (
https://gerrit.osmocom.org/c/osmo-trx/+/39359?usp=email )
Change subject: comma_delimited_to_vector() optimization CID#465430
......................................................................
comma_delimited_to_vector() optimization CID#465430
(I am not sure about this, just doing as coverity says.)
Change-Id: I30e57c6a9df39552bc4f8c18d27bc421f5c60f49
---
M CommonLibs/Utils.cpp
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
fixeria: Looks good to me, but someone else must approve
Hoernchen: Looks good to me, approved
Jenkins Builder: Verified
laforge: Looks good to me, but someone else must approve
diff --git a/CommonLibs/Utils.cpp b/CommonLibs/Utils.cpp
index 3ab598d..6703531 100644
--- a/CommonLibs/Utils.cpp
+++ b/CommonLibs/Utils.cpp
@@ -28,7 +28,7 @@
{
std::string substr;
getline(ss, substr, ',');
- result.push_back(substr);
+ result.push_back(std::move(substr));
}
return result;
}
--
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/39359?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: I30e57c6a9df39552bc4f8c18d27bc421f5c60f49
Gerrit-Change-Number: 39359
Gerrit-PatchSet: 1
Gerrit-Owner: neels <[email protected]>
Gerrit-Reviewer: Hoernchen <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <[email protected]>
Gerrit-Reviewer: laforge <[email protected]>
