Attention is currently required from: pespin.

lynxis lazus has posted comments on this change by lynxis lazus. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39254?usp=email )

Change subject: SGSN: TC_attach_gmm_attach_req_while_gmm_attach: fix test case
......................................................................


Patch Set 2:

(2 comments)

File sgsn/BSSGP_ConnHdlr.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39254/comment/81439817_1b438c02?usp=email
 :
PS2, Line 534: function f_random_ptmsi(OCT1 suffix := '00'O) return OCT4 {
> library/Osmocom_Gb_Types.ttcn […]
Unsure what you want to tell me here.
TLLI != P-TMSI. I also want to have a suffix. Further the or4b doesn't seem the 
right for me, because I explicit want to have 0xc0 in the highest byte and not 
0xcX, where X is random.


File sgsn/SGSN_Tests.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39254/comment/b9e85387_8726cb5f?usp=email
 :
PS2, Line 2088:         f_vty_config(SGSNVTY, "sgsn", "auth-policy accept-all");
> why was this removed?
Because the test case doesn't require it, nor is this feature supported in the 
future.



--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39254?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I026499844940d4c3d82b0fbd61be636c6ca348e6
Gerrit-Change-Number: 39254
Gerrit-PatchSet: 2
Gerrit-Owner: lynxis lazus <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <[email protected]>
Gerrit-Attention: pespin <[email protected]>
Gerrit-Comment-Date: Mon, 27 Jan 2025 22:28:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <[email protected]>

Reply via email to