Attention is currently required from: pespin. lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39254?usp=email )
Change subject: SGSN: TC_attach_gmm_attach_req_while_gmm_attach: fix test case ...................................................................... Patch Set 2: (2 comments) File sgsn/SGSN_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39254/comment/e1e8d923_1d258a21?usp=email : PS2, Line 2044: /* send out a second GMM_Attach Request. > this comment no longer matches the code, you moved the second attach above... > […] because the test case doesn't work this way anymore (or as soon libvlr is used). I'll remove case https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39254/comment/c442672b_3f8e1551?usp=email : PS2, Line 2050: [] as_gmm_auth(umts_aka_challenge := true, expect_sai := true) {}; > AFAIU the auth is exected to happen at the end of the whole alt? maybe simply > move it outside to exp […] I don't see what's the problem. The flow is something like this: -> Attach Req (tmsi unknown) <- Id Req -> Id Resp HLR: SAI -> Attach Req (2nd) The second Attach Req should be ignored by the SGSN, because it contains the same Attach Req. <- Auth Req -> Auth Resp HLR: LU/ISD <- Attach Accept -> Attach Complete -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39254?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I026499844940d4c3d82b0fbd61be636c6ca348e6 Gerrit-Change-Number: 39254 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <[email protected]> Gerrit-Attention: pespin <[email protected]> Gerrit-Comment-Date: Mon, 27 Jan 2025 22:37:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <[email protected]>
