Attention is currently required from: Hoernchen. laforge has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/39445?usp=email )
Change subject: fix usb usb reset handling by delayed soft reset ...................................................................... Patch Set 1: (2 comments) File sysmoOCTSIM/hpl/core/hpl_init.c: https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/39445/comment/4934ec45_ff932e9d?usp=email : PS1, Line 57: // _osc32kctrl_init_sources(); : // _oscctrl_init_sources(); : // _mclk_init(); : // #if _GCLK_INIT_1ST : // _gclk_init_generators_by_fref(_GCLK_INIT_1ST); : // #endif : // _oscctrl_init_referenced_generators(); > Because this serves as a reminder what must be done to run the fw without a > bl + allows conveniently […] I'd recommend to put it in a #if 0 / #endif block and include a comment stating the purpose. or what about a self-explanatory ``` #define BOOT_WITHOUT_BOOTLOADER 0 #if BOOT_WITHOUT_BOOTLOADER != 0 ... #endif ``` or the like? File sysmoOCTSIM/main.c: https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/39445/comment/6dd0aad9_86b5ecb0?usp=email : PS1, Line 579: if(delayed_usb_reset) > the format issues happened during cleanup and merging of a dozen different > branches with code in sep […] can we please avoid introducing more code that's not formatted correctly? I really don't want to have those kind of debates. 99.5% of all patches we review in gerrit are not raising obvious whitespace/formatting issues, AFAICT. -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/39445?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: I0939930a42f3009abf7e670561a123963bbd3845 Gerrit-Change-Number: 39445 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen <ew...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <lafo...@osmocom.org> Gerrit-Attention: Hoernchen <ew...@sysmocom.de> Gerrit-Comment-Date: Thu, 30 Jan 2025 15:47:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Hoernchen <ew...@sysmocom.de> Comment-In-Reply-To: laforge <lafo...@osmocom.org>
