Attention is currently required from: Hoernchen. laforge has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/39445?usp=email )
Change subject: fix usb usb reset handling by delayed soft reset ...................................................................... Patch Set 3: Code-Review+1 (1 comment) File sysmoOCTSIM/hpl/core/hpl_init.c: https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/39445/comment/ce83f0f5_19cf2c12?usp=email : PS3, Line 63: // _oscctrl_init_referenced_generators(); here we have again those length commented-out blocks of code (even with single-line commenting). I don't get why we do this. Either we expect to need that code in the future in some situations - then there should be at least a human-readable comment explaining it, or ideally some #ifdef foo ... clause for the normal and non-standard situation. Or it's old cruft that is not needed and hence it can be removed; anyone interested can see in the commitlog. -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/39445?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: I0939930a42f3009abf7e670561a123963bbd3845 Gerrit-Change-Number: 39445 Gerrit-PatchSet: 3 Gerrit-Owner: Hoernchen <ew...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <lafo...@osmocom.org> Gerrit-Attention: Hoernchen <ew...@sysmocom.de> Gerrit-Comment-Date: Wed, 12 Feb 2025 14:20:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes
