[M] Change in osmo-bsc[master]: nokia_site: Add object_identity, object_state and object_identity_sta...

[pespin]

Attention is currently required from: csaba.sipos, fixeria.

pespin has posted comments on this change by csaba.sipos. ( 
https://gerrit.osmocom.org/c/osmo-bsc/+/39416?usp=email )

Change subject: nokia_site: Add object_identity, object_state and 
object_identity_state attributes
......................................................................


Patch Set 5: Code-Review+1

(1 comment)

File src/osmo-bsc/bts_nokia_site.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/39416/comment/68f482e4_4ec607aa?usp=email
 :
PS5, Line 1823:                 if (find_element(noh->data, len_data, 
NOKIA_EI_OBJ_ID_STATE, object_id_state, sizeof(object_id_state))) {
can we pelase use early return to simplify code:

    if (!find_element(...) {
      LOG_BTS("missing...");
      return -EINVAL;
    }
    LOG_BTS("State changed");



--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/39416?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Id9f819b0649ba3c247db72d7d738e49c72388dc3
Gerrit-Change-Number: 39416
Gerrit-PatchSet: 5
Gerrit-Owner: csaba.sipos <met...@freemail.hu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanits...@sysmocom.de>
Gerrit-Reviewer: pespin <pes...@sysmocom.de>
Gerrit-Attention: csaba.sipos <met...@freemail.hu>
Gerrit-Attention: fixeria <vyanits...@sysmocom.de>
Gerrit-Comment-Date: Mon, 03 Feb 2025 10:05:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes