Attention is currently required from: csaba.sipos, fixeria, laforge. pespin has posted comments on this change by csaba.sipos. ( https://gerrit.osmocom.org/c/osmo-bsc/+/39416?usp=email )
Change subject: nokia_site: Add object_identity, object_state and object_identity_state attributes ...................................................................... Patch Set 9: (3 comments) Patchset: PS9: I'm sorry to keep delaying merge of this, but I ask for simpel changes sometimes and then new version seems to have changed substantially again from last version.. File src/osmo-bsc/bts_nokia_site.c: https://gerrit.osmocom.org/c/osmo-bsc/+/39416/comment/f6d8f8dc_f44bfee2?usp=email : PS9, Line 1857: if (find_element(noh->data, len_data, NOKIA_EI_OBJ_ID, object_identity, sizeof(object_identity)) != sizeof(object_identity) || This is now tons of lines >120 chars (the maximum as per osmocom guidelines) and becomes unreadable when looking at diffs. Also, it's really really hard to follow on this since it's full of several levels of if/else everywhere. https://gerrit.osmocom.org/c/osmo-bsc/+/39416/comment/7bdbe075_0c197e56?usp=email : PS9, Line 1858: find_element(noh->data, len_data, NOKIA_EI_OBJ_STATE, &object_state, sizeof(object_state)) != sizeof(object_state)) { this is not properly aligned to the line above. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/39416?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Id9f819b0649ba3c247db72d7d738e49c72388dc3 Gerrit-Change-Number: 39416 Gerrit-PatchSet: 9 Gerrit-Owner: csaba.sipos <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <[email protected]> Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-Attention: csaba.sipos <[email protected]> Gerrit-Attention: laforge <[email protected]> Gerrit-Attention: fixeria <[email protected]> Gerrit-Comment-Date: Wed, 05 Feb 2025 13:23:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No
