Attention is currently required from: laforge, pespin. lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-iuh/+/38946?usp=email )
Change subject: iu_client: add ranap_iu_page_cs2/ranap_iu_page_ps2 ...................................................................... Patch Set 12: (4 comments) File src/iu_client.c: https://gerrit.osmocom.org/c/osmo-iuh/+/38946/comment/0fdb0a44_fa7f4a49?usp=email : PS10, Line 869: /* find all RNCs which are serving this RNC */ > Acknowledged Done https://gerrit.osmocom.org/c/osmo-iuh/+/38946/comment/3c8e47ab_9403d5fd?usp=email : PS10, Line 878: osmo_rnc_id_name(&rnc->rnc_id), > this indentation may be wrong. Done https://gerrit.osmocom.org/c/osmo-iuh/+/38946/comment/119f633d_bbb4a27c?usp=email : PS10, Line 883: } else if (!is_ps && !osmo_lai_cmp(&entry->rai.lac, &ra_id->lac)) { > this "else" can be removed in this line, simplifying logic. Done https://gerrit.osmocom.org/c/osmo-iuh/+/38946/comment/25943e12_be9f24e8?usp=email : PS10, Line 932: return iu_page2(imsi, tmsi, &rai, false); > Acknowledged Done -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/38946?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: I1f07e96642737160d387de3e4c3f71d288d356dd Gerrit-Change-Number: 38946 Gerrit-PatchSet: 12 Gerrit-Owner: lynxis lazus <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-Attention: laforge <[email protected]> Gerrit-Attention: pespin <[email protected]> Gerrit-Comment-Date: Mon, 17 Feb 2025 14:33:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <[email protected]> Comment-In-Reply-To: lynxis lazus <[email protected]>
