Attention is currently required from: pespin.

lynxis lazus has posted comments on this change by lynxis lazus. ( 
https://gerrit.osmocom.org/c/osmo-iuh/+/38946?usp=email )

Change subject: iu_client: add ranap_iu_page_cs2/ranap_iu_page_ps2
......................................................................


Patch Set 10:

(2 comments)

File src/iu_client.c:

https://gerrit.osmocom.org/c/osmo-iuh/+/38946/comment/6049ab96_a33714a8?usp=email
 :
PS10, Line 869:         /* find all RNCs which are serving this RNC */
> something is wrong in this sentence regarding a "RNC serving a RNC".
Acknowledged


https://gerrit.osmocom.org/c/osmo-iuh/+/38946/comment/ee10422f_eba753d9?usp=email
 :
PS10, Line 932:         return iu_page2(imsi, tmsi, &rai, false);
> I really wonder, does it really make sense to have a helper function for both 
> CS and PS where you ac […]
Acknowledged



--
To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/38946?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: osmo-iuh
Gerrit-Branch: master
Gerrit-Change-Id: I1f07e96642737160d387de3e4c3f71d288d356dd
Gerrit-Change-Number: 38946
Gerrit-PatchSet: 10
Gerrit-Owner: lynxis lazus <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-Reviewer: pespin <[email protected]>
Gerrit-Attention: pespin <[email protected]>
Gerrit-Comment-Date: Mon, 17 Feb 2025 10:51:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <[email protected]>

Reply via email to