Attention is currently required from: neels.

laforge has posted comments on this change by neels. ( 
https://gerrit.osmocom.org/c/pysim/+/39745?usp=email )

Change subject: [5/6] personalization: refactor AlgorithmID, K, Opc
......................................................................


Patch Set 3:

(1 comment)

File pySim/esim/saip/personalization.py:

https://gerrit.osmocom.org/c/pysim/+/39745/comment/23d923bc_40a42058?usp=email :
PS3, Line 551:     allow_len = int(128/8) # length in bytes (from BinaryParam)
> You mean the length of 128 bit? I have no idea!! Will have to check, thanks! 
> […]
just look at the pysim-shell code for setting the values on a sysmoISIM card:

        # TUAK has a rather different layout for the data, so we define a 
different
        # construct below and use explicit _{decode,encode}_bin() methods for 
separating
        # the TUAK and non-TUAK situation
        CfgByteTuak = BitStruct(Padding(1),
                                'key_length'/Mapping(Bit, {128:0, 256:1}),
                                'sres_deriv_func_in_2g'/Mapping(Bit, {1:0, 
2:1}),
                                'use_opc_instead_of_op'/Mapping(Bit, {False:0, 
True:1}),
                                'algorithm'/Algorithm)
        TuakCfgByte = BitStruct(Padding(1),
                                'ck_and_ik_size'/Mapping(Bit, {128:0, 256:1}),
                                'mac_size'/Mapping(BitsInteger(3), {64:0, 
128:1, 256:2}),
                                'res_size'/Mapping(BitsInteger(3), {32:0, 64:1, 
128:2, 256:3}))



--
To view, visit https://gerrit.osmocom.org/c/pysim/+/39745?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I6296fdcfd5d2ed313c4aade57ff43cc362375848
Gerrit-Change-Number: 39745
Gerrit-PatchSet: 3
Gerrit-Owner: neels <nhofm...@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <lafo...@osmocom.org>
Gerrit-Attention: neels <nhofm...@sysmocom.de>
Gerrit-Comment-Date: Thu, 27 Mar 2025 20:00:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: neels <nhofm...@sysmocom.de>
Comment-In-Reply-To: laforge <lafo...@osmocom.org>

Reply via email to