Attention is currently required from: laforge. neels has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/pysim/+/39745?usp=email )
Change subject: [5/6] personalization: refactor AlgorithmID, K, Opc ...................................................................... Patch Set 4: (1 comment) File pySim/esim/saip/personalization.py: https://gerrit.osmocom.org/c/pysim/+/39745/comment/d2c44a7d_af409c41?usp=email : PS3, Line 551: allow_len = int(128/8) # length in bytes (from BinaryParam) > just look at the pysim-shell code for setting the values on a sysmoISIM card: > […] I'm sorry, I do not comprehend this code snippet at all... Can you decipher for me, I just need to know: what valid lengths can any K have for TUAK (and any other algo)? (matching a K length to a chosen algo will have to be done by a later integrity check, because there currently is no relation between separate ConfigurableParameters) We could also merge this patch now, because it supports Milenage, and fix TUAK later...? -- To view, visit https://gerrit.osmocom.org/c/pysim/+/39745?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I6296fdcfd5d2ed313c4aade57ff43cc362375848 Gerrit-Change-Number: 39745 Gerrit-PatchSet: 4 Gerrit-Owner: neels <nhofm...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <lafo...@osmocom.org> Gerrit-Attention: laforge <lafo...@osmocom.org> Gerrit-Comment-Date: Sat, 19 Apr 2025 22:13:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofm...@sysmocom.de> Comment-In-Reply-To: laforge <lafo...@osmocom.org>
