Attention is currently required from: clufn, laforge.

pespin has posted comments on this change by clufn. ( 
https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/40255?usp=email )

Change subject: Add required conversions for IPv6 and IPv4v6 support
......................................................................


Patch Set 5:

(2 comments)

File src/conv.erl:

https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/40255/comment/26ce07a3_6955b4b0?usp=email
 :
PS5, Line 72: add_prefix(<<A:8, B:8, C:8, D:8, E:8, F:8, G:8, H:8, I:8, J:8, 
K:8, L:8, M:8, N:8, O:8, P:8>>) ->
> There is a second patch coming that uses the IP address requested by the UE 
> is the IKE_AUTH request  […]
Then please submit this function when it is needed, not here 😊


https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/40255/comment/4f4518ab_60f5ab67?usp=email
 :
PS5, Line 136:                   ipv6 = remove_prefix(Addr)};
> The IPv6 Address send by the epc has a prefix bit that causes issues in the 
> epdg
can you point to the related spec, or open a ticket in redmine with a pcap file 
or similar?



--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/40255?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: erlang/osmo-epdg
Gerrit-Branch: master
Gerrit-Change-Id: I2426e0dcee3ca92075b845f6b21a175a3d047c08
Gerrit-Change-Number: 40255
Gerrit-PatchSet: 5
Gerrit-Owner: clufn <callumfarrbenn...@yahoo.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <lafo...@osmocom.org>
Gerrit-CC: pespin <pes...@sysmocom.de>
Gerrit-Attention: laforge <lafo...@osmocom.org>
Gerrit-Attention: clufn <callumfarrbenn...@yahoo.com>
Gerrit-Comment-Date: Thu, 08 May 2025 09:04:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pes...@sysmocom.de>
Comment-In-Reply-To: clufn <callumfarrbenn...@yahoo.com>

Reply via email to