Attention is currently required from: laforge, pespin.

clufn has posted comments on this change by clufn. ( 
https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/40255?usp=email )

Change subject: Add required conversions for IPv6 and IPv4v6 support
......................................................................


Patch Set 6:

(1 comment)

File src/conv.erl:

https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/40255/comment/411be856_1857d63e?usp=email
 :
PS5, Line 69: remove_prefix(<<A:8, Rest/binary>>) when is_binary(Rest) ->
> can we have a more descriptive name for this one?
Done



--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/40255?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: erlang/osmo-epdg
Gerrit-Branch: master
Gerrit-Change-Id: I2426e0dcee3ca92075b845f6b21a175a3d047c08
Gerrit-Change-Number: 40255
Gerrit-PatchSet: 6
Gerrit-Owner: clufn <callumfarrbenn...@yahoo.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <lafo...@osmocom.org>
Gerrit-CC: pespin <pes...@sysmocom.de>
Gerrit-Attention: laforge <lafo...@osmocom.org>
Gerrit-Attention: pespin <pes...@sysmocom.de>
Gerrit-Comment-Date: Thu, 08 May 2025 09:30:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pes...@sysmocom.de>

Reply via email to