Patch Set 1: (3 comments)
https://gerrit.osmocom.org/#/c/6324/1/include/osmocom/bsc/acc_ramp.h File include/osmocom/bsc/acc_ramp.h: Line 20: #ifndef _ACC_RAMP_H_ Do we still use this way of the include guard? Why now '#pragma once'? https://gerrit.osmocom.org/#/c/6324/1/src/libbsc/chan_alloc.c File src/libbsc/chan_alloc.c: Line 660: if (bts->chan_load_avg > 100) /* sanity check; should not happen */ Why not to use OSMO_ASSERT if this should not happen? https://gerrit.osmocom.org/#/c/6324/1/src/libbsc/system_information.c File src/libbsc/system_information.c: PS1, Line 679: if (bts->acc_ramping_enabled) { : si1->rach_control.t2 |= acc_ramp_get_barred_t2(&bts->acc_ramp); : si1->rach_control.t3 |= acc_ramp_get_barred_t3(&bts->acc_ramp); : } This block appears multiple times, so what do you think about using a #define ...? -- To view, visit https://gerrit.osmocom.org/6324 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0a5ac3a08f992f326435944f17e0a9171911afb0 Gerrit-PatchSet: 1 Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Owner: Stefan Sperling <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Stefan Sperling <[email protected]> Gerrit-Reviewer: Vadim Yanitskiy <[email protected]> Gerrit-HasComments: Yes
