Attention is currently required from: jolly, laforge.

pespin has posted comments on this change by jolly. ( 
https://gerrit.osmocom.org/c/libosmocore/+/40725?usp=email )

Change subject: Automatically increase io_uring, if too small.
......................................................................


Patch Set 3:

(1 comment)

Patchset:

PS2:
> this was based on a discussion aeversberg and I had before he started to wrok 
> on the patch. […]
I foresee lots of weird stuff happening only in those "super-rare events" we 
may not think about or which may end up with undefined behavior, eg. with one 
socket ending up with sqes in 2 different rings.

IMHO we should explore the possibility of, in case io_uring_get_sqe() fails, 
append the osmo_iofd to some sort of "wait_read_sqe_queue" which is 
re-attempted every time a completed() event happen on the queue.

This sounds like a lot less trouble now and in the future.



--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/40725?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Id9230146acc8d54bfd44834e783c31b37bd64bca
Gerrit-Change-Number: 40725
Gerrit-PatchSet: 3
Gerrit-Owner: jolly <andr...@eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <lafo...@osmocom.org>
Gerrit-CC: pespin <pes...@sysmocom.de>
Gerrit-Attention: jolly <andr...@eversberg.eu>
Gerrit-Attention: laforge <lafo...@osmocom.org>
Gerrit-Comment-Date: Wed, 23 Jul 2025 14:39:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <lafo...@osmocom.org>
Comment-In-Reply-To: pespin <pes...@sysmocom.de>

Reply via email to