Attention is currently required from: jolly, pespin.

laforge has posted comments on this change by jolly. ( 
https://gerrit.osmocom.org/c/libosmocore/+/40725?usp=email )

Change subject: Automatically increase io_uring, if too small.
......................................................................


Patch Set 3:

(1 comment)

Patchset:

PS2:
> I foresee lots of weird stuff happening only in those "super-rare events" we 
> may not think about or  […]
I think having two rings and gradually migrating over is clean, and we can test 
the scenario by running [automatic] tests with artificially low initial ring 
sizes to make sure we trigger the ring resize process.

Dynamically resizing data structures based on need/load is pretty standard 
procedure.  I'd rather make use of the facilities io_uring provides (multiple 
rings) rather than working around it with some queuing mechanism.  that 
mechanism also will need testing, just like any mechanism dealing with sqe (or 
even cqe) overflow.



--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/40725?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Id9230146acc8d54bfd44834e783c31b37bd64bca
Gerrit-Change-Number: 40725
Gerrit-PatchSet: 3
Gerrit-Owner: jolly <andr...@eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <lafo...@osmocom.org>
Gerrit-CC: pespin <pes...@sysmocom.de>
Gerrit-Attention: jolly <andr...@eversberg.eu>
Gerrit-Attention: pespin <pes...@sysmocom.de>
Gerrit-Comment-Date: Wed, 23 Jul 2025 19:17:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <lafo...@osmocom.org>
Comment-In-Reply-To: pespin <pes...@sysmocom.de>

Reply via email to