Attention is currently required from: jolly, laforge. pespin has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/libosmocore/+/40725?usp=email )
Change subject: Automatically increase io_uring, if too small. ...................................................................... Patch Set 12: (2 comments) File src/core/osmo_io_uring.c: https://gerrit.osmocom.org/c/libosmocore/+/40725/comment/08a6dfef_9a46a235?usp=email : PS9, Line 208: /* All subsequent read SQEs must be on the same ring. */ > iofd_uring_get_sqe() has no knowledge about the iofd, so it doesn't know if > there are SQEs already s […] yeah well that's my point, a function named "iofd_" can perfectly get passed an iofd and do that logic there :) https://gerrit.osmocom.org/c/libosmocore/+/40725/comment/9fd6e9d6_f25f8240?usp=email : PS9, Line 282: while (iofd->u.uring.reads_submitted < ((iofd->u.uring.num_read_sqes) ? : g_io_uring_read_sqes)) { > if iofd instance is created, num_read_sqes (read.num_sques now) is not set by > the user, so that it is 0. why aren't we setting num_read_sqes to g_io_uring_read_sques by default when the iofd is allocated? Not doing so looks very confusing to me. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/40725?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Id9230146acc8d54bfd44834e783c31b37bd64bca Gerrit-Change-Number: 40725 Gerrit-PatchSet: 12 Gerrit-Owner: jolly <andr...@eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <lafo...@osmocom.org> Gerrit-CC: pespin <pes...@sysmocom.de> Gerrit-Attention: jolly <andr...@eversberg.eu> Gerrit-Attention: laforge <lafo...@osmocom.org> Gerrit-Comment-Date: Mon, 18 Aug 2025 10:20:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: jolly <andr...@eversberg.eu> Comment-In-Reply-To: pespin <pes...@sysmocom.de>
