Attention is currently required from: jolly. pespin has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/libosmocore/+/40855?usp=email )
Change subject: Remove old empty io_uring ...................................................................... Patch Set 3: (3 comments) Commit Message: https://gerrit.osmocom.org/c/libosmocore/+/40855/comment/532892e6_fa73b16f?usp=email : PS3, Line 14: The counter is decrements whenever a CQE is received and handled. This is decremeted File src/core/osmo_io_uring.c: https://gerrit.osmocom.org/c/libosmocore/+/40855/comment/3285e255_73e513e9?usp=email : PS3, Line 76: unsigned int in_flight; "num_in_transit" woulb be better imho, or at least "num_in_flight" to quickly denote it's counter and not a boolean. Maybe also "num_pending_reqs". https://gerrit.osmocom.org/c/libosmocore/+/40855/comment/daedf8d9_7938a8a1?usp=email : PS3, Line 639: ring->in_flight++; Sounds like we may want to have a wrapper around io_uring_get_sqe() which increases in_flight if sqe was obtained. I see this same pattern is done in multiple non-related code paths. This way we may avoid skipping the step if we add new code or change it. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/40855?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Id2d2a0400ad442198c684ea0ead4eaeaead4c53d Gerrit-Change-Number: 40855 Gerrit-PatchSet: 3 Gerrit-Owner: jolly <andr...@eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pes...@sysmocom.de> Gerrit-Attention: jolly <andr...@eversberg.eu> Gerrit-Comment-Date: Mon, 18 Aug 2025 10:28:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No
